Replace CountDownLatch with Deferred in BatchSpanProcessor - #119
Open
MattNot wants to merge 4 commits into
Open
Conversation
…signal handling.
Contributor
|
Hey, thanks for the contribution! Looks good to me. Once tests are green, we can merge and release. |
Author
|
Added a commit to optimize also the pollWaitTime <= Duration.Zero && currentBatchSize == 0 scenario |
iRevive
reviewed
Jul 28, 2026
Comment on lines
+123
to
+124
| currentSignal <- signalRef.getAndSet(newSignal) | ||
| _ <- currentSignal.get.timeoutTo(pollWaitTime, unit) |
Contributor
There was a problem hiding this comment.
Here, we first get an existing deferred (let's call it old), then set a new one.
And in line 124 we wait for the completion of the old one, while the notifyWorker completes the new one.
So, the old will never be completed, and we always go through the timeout scenario.
Contributor
There was a problem hiding this comment.
Perhaps we can drop intermediate synchronization/notification and wait directly on queue.take. I will explore this idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles #118