Coerce built-in scalars and reject invalid values - #956
Open
hugo-vrijswijk wants to merge 1 commit into
Open
hugo-vrijswijk wants to merge 1 commit into
hugo-vrijswijk wants to merge 1 commit into
Conversation
Fixes #955 Attempts to coerce built-in scalar values to the expected type (`42` -> `"42"` for `String`, etc). Reject values that cannot be coerced (e.g. `true` for `Float`) rather than returning an incorrect type. Coercion is specified in the GraphQL spec: https://spec.graphql.org/September2025/#sec-Scalars.Result-Coercion-and-Serialization. No specific rules are mentioned for what _should_ or _shouldn't_ be coerced, instead it is left to the implementation.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #955
Attempts to coerce built-in scalar values to the expected type (
42->"42"forString, etc). Reject values that cannot be coerced (e.g.trueforFloat) rather than returning an incorrect type.Coercion is specified in the GraphQL spec: https://spec.graphql.org/September2025/#sec-Scalars.Result-Coercion-and-Serialization. No specific rules are mentioned for what should or shouldn't be coerced, instead it is left to the implementation.