Keep a warning's problems when it is combined with a failure - #952
Merged
hugo-vrijswijk merged 1 commit intoSep 28, 2026
Merged
hugo-vrijswijk merged 1 commit into
hugo-vrijswijk merged 1 commit into
Conversation
hugo-vrijswijk
approved these changes
Sep 28, 2026
hugo-vrijswijk
left a comment
hugo-vrijswijk
left a comment
Contributor
There was a problem hiding this comment.
This makes sense to me. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While doing a
parSequenceon a list ofResults, I found that Problems were accumulated for Warnings, but only until a Failure was found in the list. After that, the Problems of new Failures were accumulated, but new Warnings were ignored.This seems to be an oversight rather than a conscious decision. For comparison, cats
Ioraccumulates in both directions.Note that the current implementation is lawful since the Applicative laws only constrain the values. This is why the laws tests did not catch it. But it does seem inconsistent to me.
claude wrote the test.