TWO-24856/feat: Brand seams for checkout subtitle and API-key contact#340
Open
dgjlindsay wants to merge 2 commits into
Open
TWO-24856/feat: Brand seams for checkout subtitle and API-key contact#340dgjlindsay wants to merge 2 commits into
dgjlindsay wants to merge 2 commits into
Conversation
Add two brand-overlayable surfaces so a brand edition can match the cross-platform brand presentation without forking: - get_pay_subtitle renders an optional checkout_subtitle brand key as a tagline above the about block; '' (the Two default) renders nothing, so existing Two checkout is unchanged. - The admin API-key field help now names a production-key contact from a new production_key_contact_email brand key (default integration@two.inc) so an overlay can substitute its own support address. Brand defaults pinned in tests/unit. PHP 7.4 + 8.2 green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The brand-seam tests and the confirmation-URL hook docblock illustrated the overlay pattern with a partner-specific plugin slug. Swap it for a neutral 'example-overlay-gateway' so the canonical plugin carries no partner-brand identifiers. Illustrative only — no behaviour change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
🖌 Pre-commit success 🏆DetailsExit code: 0 Author ✍️@dgjlindsay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two brand-overlayable surfaces on the brand-config layer, so a brand edition can match the cross-platform brand presentation without forking:
get_pay_subtitle()renders an optionalcheckout_subtitlebrand key as a tagline above the about block. Default''(Two) renders nothing, so existing Two checkout is unchanged.production_key_contact_emailbrand key (defaultintegration@two.inc). An overlay substitutes its own support address.Also neutralises a partner-specific example slug in the tests + confirmation-URL docblock (now
example-overlay-gateway) so the canonical plugin carries no partner identifiers. Illustrative only.Why
Closes the brand-seam half of the cross-platform brand parity audit (TWO-24856). The Magento brand layer already exposes equivalents; these were the missing WooCommerce seams.
Test
tests/unitpins the new brand defaults; PHP 7.4 + 8.2 green.Targets
staging.🤖 Generated with Claude Code