TWO-24740/chore: Remove sync endpoints, status endpoint, before_order_update#319
Open
dgjlindsay wants to merge 2 commits into
Open
TWO-24740/chore: Remove sync endpoints, status endpoint, before_order_update#319dgjlindsay wants to merge 2 commits into
dgjlindsay wants to merge 2 commits into
Conversation
…_update Removes the four order-sync REST endpoints (twoinc_list_out_of_sync_order_ids, twoinc_sync_order_state, twoinc_get_plugin_configs, twoinc_get_order_info), the unauthenticated twoinc_plugin_status_checking endpoint (exposed plugin version publicly), their auth helper auth_rest_request, and the before_order_update save_post hook long marked @todo for removal. The backend caller (sync_woocom_order_status batch job) is removed in checkout-api#12260; its CronJob triggers in two-app-values#1674. The status_to_states map was only used by the removed handlers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
🖌 Pre-commit success 🏆DetailsExit code: 0 Author ✍️@dgjlindsay |
Its only caller was the get_order_info sync endpoint removed in the previous commit (adversarial review finding). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
twoinc_list_out_of_sync_order_ids,twoinc_sync_order_state,twoinc_get_plugin_configs,twoinc_get_order_info(registrations + wrappers + handlers)twoinc_plugin_status_checking— unauthenticated, publicly exposed the plugin versionWC_Twoinc_Helper::auth_rest_request()— only used by the removed endpointsbefore_order_update()+ itssave_post_shop_orderhook — marked@TODO: Edit rework: remove this function after edit is stable$status_to_states— only consumed by the removed handlersWhy
Production log analysis (TWO-24740 gap analysis) confirms the nightly backend sync jobs calling these endpoints were either broken or only correcting stale local WP metadata with no Two API mutations.
before_order_updatepre-seeded_twoinc_req_body_hashon each admin edit; with it gone the hash baseline is simply the one stored at last successful Two sync (process_update_twoinc_order), which is the correct comparison anyway.Deploy order
This is step 3 of three (chain: CronJob → checkout-api handler → plugin endpoint):
🤖 Generated with Claude Code