asText survives parseFilter output: to_unicode instead of .decode() (fixes #248) - #259
Merged
Conversation
…ixes #248) parseFilter builds LDAPFilter_* objects whose .value fields are str, because pyparsing hands us str. Every asText path in pureldap called .value.decode() unconditionally, which crashed with AttributeError: 'str' object has no attribute 'decode' the moment a caller tried to render a parsed filter (rather than a wire-decoded one). Route the ten remaining sites through to_unicode so both origins work. Regression test covers equality, presence, substring, approxMatch, greater/lessOrEqual and extensibleMatch. Full suite green on py3.11 / 3.13 / 3.14.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asText survives parseFilter output: to_unicode instead of .decode() (fixes #248)
parseFilter builds LDAPFilter_* objects whose .value fields are str, because pyparsing hands us str. Every asText path in pureldap called .value.decode() unconditionally, which crashed with AttributeError: 'str' object has no attribute 'decode' the moment a caller tried to render a parsed filter (rather than a wire-decoded one). Route the ten remaining sites through to_unicode so both origins work. Regression test covers equality, presence, substring, approxMatch, greater/lessOrEqual and extensibleMatch.
Full suite green on py3.11 / 3.13 / 3.14.