LDAPClient.unbind returns a Deferred that fires on actual disconnect (fixes #225) - #258
Merged
Conversation
…ixes #225) Also add LDAPClient.notifyOnDisconnect() so callers can register their own disconnect Deferreds without initiating an unbind. Matters for TLS teardown, which can take noticeably longer than TCP FIN and previously left callers hoping the loseConnection had actually completed. Backwards compatible: existing callers that ignore unbind()'s return value keep working; the ones that need to wait now can.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LDAPClient.unbind returns a Deferred that fires on actual disconnect (fixes #225)
Also add LDAPClient.notifyOnDisconnect() so callers can register their own disconnect Deferreds without initiating an unbind. Matters for TLS teardown, which can take noticeably longer than TCP FIN and previously left callers hoping the loseConnection had actually completed.
Backwards compatible: existing callers that ignore unbind()'s return value keep working; the ones that need to wait now can.