Support LDAPModifyDNRequest with deleteoldrdn=False on the server (fixes #89) - #257
Merged
Conversation
#89) The server used to raise LDAPUnwillingToPerform for the "preserve old RDN" case. Add a deleteOldRDN kwarg on inmemory move / _move / _move2, plumb it through the client-side ldapsyntax.LDAPEntry.move, and thread the wire flag through handle_LDAPModifyDNRequest. When False, the old RDN attribute value is retained on the moved entry (RFC 4511 4.9). Regression test in test_server covers the preserve-old-RDN success path. Full suite green on py3.11 / 3.13 / 3.14.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support LDAPModifyDNRequest with deleteoldrdn=False on the server (fixes #89)
The server used to raise LDAPUnwillingToPerform for the "preserve old RDN" case. Add a deleteOldRDN kwarg on inmemory move / _move / _move2, plumb it through the client-side ldapsyntax.LDAPEntry.move, and thread the wire flag through handle_LDAPModifyDNRequest. When False, the old RDN attribute value is retained on the moved entry (RFC 4511 4.9).
Regression test in test_server covers the preserve-old-RDN success path. Full suite green on py3.11 / 3.13 / 3.14.