Batch 3: SearchByTreeWalkingMixin sizeLimit and ModifyOp round-trip - #256
Merged
Conversation
- SearchByTreeWalkingMixin.search now honors sizeLimit and stops appending matches once the requested count is reached (fixes #234). Truncation only -- the tree walk itself still runs to completion, because early cancellation would require an interruptible iterator the mixin does not expose. - delta.Modification.asLDAP no longer returns wire-encoded bytes; it returns the BERSequence object that LDAPModifyRequest.modification and ModifyOp.fromLDAP already document and expect. This fixes the ValueError: too many values to unpack round-trip failure (fixes #223). Regression tests for both. Full suite green on py3.11, 3.13, 3.14.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #256 +/- ##
==========================================
+ Coverage 83.28% 83.49% +0.20%
==========================================
Files 87 87
Lines 11567 11666 +99
Branches 1184 1004 -180
==========================================
+ Hits 9634 9740 +106
Misses 1815 1815
+ Partials 118 111 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SearchByTreeWalkingMixin.search now honors sizeLimit and stops appending matches once the requested count is reached (fixes
SearchByTreeWalkungMixinignoressizeLimit#234). Truncation only -- the tree walk itself still runs to completion, because early cancellation would require an interruptible iterator the mixin does not expose.delta.Modification.asLDAP no longer returns wire-encoded bytes; it returns the BERSequence object that LDAPModifyRequest.modification and ModifyOp.fromLDAP already document and expect. This fixes the ValueError: too many values to unpack round-trip failure (fixes Bug: ModifyOp in the Delta module cannot serialize from LDAP #223).
Regression tests for both. Full suite green on py3.11, 3.13, 3.14.