Merge in changes - #11
Open
dylanturn wants to merge 1076 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| env?: NodeJS.ProcessEnv, | ||
| ): Promise<{ stdout: string; stderr: string }> { | ||
| const CODE_SERVER_COMMAND = process.env.CODE_SERVER_PATH || path.resolve("../../release-standalone/bin/code-server") | ||
| const { stdout, stderr } = await promisify(exec)(`${CODE_SERVER_COMMAND} ${argv.join(" ")}`, { |
Check warning
Code scanning / CodeQL
Shell command built from environment values
|
You have successfully added a new CodeQL configuration |
code-asher
force-pushed
the
main
branch
2 times, most recently
from
January 11, 2024 21:26
1f28763 to
d49b3bf
Compare
code-asher
force-pushed
the
main
branch
2 times, most recently
from
May 7, 2024 21:41
5788325 to
ab4b36f
Compare
code-asher
force-pushed
the
main
branch
2 times, most recently
from
November 6, 2024 21:58
915a75a to
2c1981b
Compare
code-asher
force-pushed
the
main
branch
8 times, most recently
from
March 7, 2025 21:25
13754f3 to
cc3c22d
Compare
code-asher
force-pushed
the
main
branch
2 times, most recently
from
April 28, 2025 22:29
c5a2d06 to
dded82b
Compare
The problem was that whenever the hashe needed an update, the current patch would create a conflict which cannot be easily auto-resolved. Instead, put the hashes in a separate patch that is deleted and regenerated each time, avoiding the conflicts. Also the web worker iframe hash was not being updated.
Not sure why I assumed this would render.
This can happen if you run the update multiple times and it was already deleted from another run but not regenerated yet due to an early failure like from a conflict.
The client combines the key from this endpoint to then encrypt secrets into browser storage.
We use the cookie parser to remove the code-server token but by default it encodes using encodeURIComponent, which encodes more than is strictly necessary and can break proxied applications. Now we pass the cookies through unchanged (other than removing the code-server token). Fixes #7927.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #