[pull] master from ruby:master#1010
Merged
Merged
Conversation
When a class or module was cloned, rb_vm_rewrite_cref would rewrite the CREF chain of each cloned method to point at the new class. Remove this special case so that clone behaves consistently with all other ways of adopting a method. This also removes the RCLASS_CLONED flag which was used to prevent constant inline cache sharing between cloned classes [Bug #15877], and the vm_cref_new_use_prev helper which only existed for CREF rewriting. [Feature #21981]
This helps get rid of repeated type guards in a loop such as structaref or structaset benchmark. @dak2 originally had this in his PR but it wasn't tested so I removed it. This brings it back with a test that catches it.
Swatinem/rust-cache (embedded in actions-rust-lang/setup-rust-toolchain)
caches ${CARGO_HOME}/bin by default. When the cache is restored from a
stale or partially-populated state, the rustup proxy binaries at
~/.cargo/bin/{rustc,cargo,...} get overwritten with broken ones, leaving
rustc behaving as rustup-init.
This surfaces at make time: `rustc -V` returns the rustup version
(1.29.0) instead of the active toolchain (1.95.0), and `rustc
--crate-name=jit ...` fails with "error: unexpected argument
'--crate-name' found / Usage: rustup-init[EXE] [OPTIONS]", breaking
libjit.rlib in combo YJIT+ZJIT builds.
The macOS runner image already preinstalls rustup, so caching
~/.cargo/bin saves only a few seconds while risking exactly this kind of
poisoning. Disable it; the separate Cargo dependency cache stays on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )