[pull] master from php:master - #1320
Merged
Merged
Conversation
tidyNode objects kept raw tidy pointers after parseString() replaced the document tree. Stamp each node with the document parse generation and reject use when the generations differ. Closes GH-23937
* PHP-8.4: ext/tidy: Reject tidyNode use after the document is reparsed
* PHP-8.5: ext/tidy: Reject tidyNode use after the document is reparsed
* PHP-8.6: ext/tidy: Reject tidyNode use after the document is reparsed
The current signature is effectively useless every call uses the _ex variant to be able to grab the FCC and usually the error message. Something the current signature does not provide, and instead offers parameters that most call sites don't care about. Closes GH-23996
As the new signature is actually useful now
Document the identifier deprecations introduced by #23615 and #23709 in UPGRADING and NEWS so they are covered by the PHP 8.6 migration guide. Cover the additional uses of "_" and the deprecation of "let" and "is" as identifiers. Place the NEWS entries in the current PHP 8.6 release section. Closes #23972
* PHP-8.6: Document missing deprecation entries for PHP 8.6 (#23972) Keep PHP 8.6 NEWS and migration notes on the PHP-8.6 branch. The master branch already documents PHP 8.7.
…sion data Apply the changes from libgd/libgd@9fa3abd in order to fix undefined behavior from out-of-bounds reads when creating a GIF with problematic LZW compression data.
* PHP-8.4: NEWS ext/gd: fix undefined behavior with GIFs with problematic LZW compression data
* PHP-8.5: NEWS ext/gd: fix undefined behavior with GIFs with problematic LZW compression data
* PHP-8.6: NEWS ext/gd: fix undefined behavior with GIFs with problematic LZW compression data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )