Skip to content

Fix SIDScore vibrato instrument loading - #80

Merged
turesheim merged 3 commits into
mainfrom
codex/fix-sidscore-vibrato-controls
Aug 28, 2026
Merged

Fix SIDScore vibrato instrument loading#80
turesheim merged 3 commits into
mainfrom
codex/fix-sidscore-vibrato-controls

Conversation

@turesheim

Copy link
Copy Markdown
Owner

Summary:

  • Clear cached SID instrument state before score playback so incoming score/tune/voice state hydrates the instrument controls.
  • Add the presentation demo score with VIBRATO=0,32,128,0 for the vibrato tune so the panel receives fine-vibrato fields.

Tests:

  • java -Dsidscore.kickass.jar=resources/KickAss.jar -jar resources/sidscore-cli-0.7.1.jar example-workspace/Presentasjon/demo.sidscore --tune 5 --asm /tmp/commodore-commander-demo-tune5.asm --no-play
  • npm run build --workspace @commodore-commander/theia-extension
  • node --test packages/theia-extension/lib/test/sidscore-instrument-protocol.test.js packages/theia-extension/lib/test/sid-instrument-protocol-controls.test.js packages/theia-extension/lib/test/sid-instrument-vibrato.test.js packages/theia-extension/lib/test/sidscore-playback-routing.test.js

Notes:

  • Other pre-existing dirty example-workspace/reference files were not included in this PR.

@turesheim
turesheim merged commit 423351f into main Aug 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant