fix: no async polling deadline on zero timeout#233
Merged
Conversation
The `Timeout` class documents that a timeout value of `Duration.ZERO` means "no timeout". This requires special treatment in the `Deadline` class used by async polling, which would otherwise interpret a zero timeout as "a timeout after zero nanoseconds".
teskje
force-pushed
the
jan/fix-async-polling-timeout
branch
from
adafc6a to
c7d2d33
Compare
benesch
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Timeoutclass documents that a timeout value ofDuration.ZEROmeans "no timeout". This requires special treatment in theDeadlineclass used by async polling, which would otherwise interpret a zero timeout as "a timeout after zero nanoseconds".Found by bugbot on the release PR.