Skip to content

libobs/media-io: Specify codec tag when it is compatible in out stream #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tuduweb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

libobs/media-io: Specify codec tag when it is compatible in out stream #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions libobs/media-io/media-remux.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,17 +153,21 @@ static inline bool init_output(media_remux_job_t job, const char *out_filename)
av_dict_copy(&out_stream->metadata, in_stream->metadata, 0);

#if LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(57, 48, 101)
if (in_stream->codecpar->codec_id == AV_CODEC_ID_HEVC &&
job->ofmt_ctx->oformat->codec_tag &&
if(!job->ofmt_ctx->oformat->codec_tag) {
out_stream->codecpar->codec_tag = 0;
}else if(in_stream->codecpar->codec_id == AV_CODEC_ID_HEVC &&
av_codec_get_id(job->ofmt_ctx->oformat->codec_tag,
MKTAG('h', 'v', 'c', '1')) ==
out_stream->codecpar->codec_id) {
MKTAG('h', 'v', 'c', '1')) {
// Tag HEVC files with industry standard HVC1 tag for wider device compatibility
// when HVC1 tag is supported by out stream codec
out_stream->codecpar->codec_tag =
MKTAG('h', 'v', 'c', '1');
} else {
// Otherwise tag 0 to let FFmpeg automatically select the appropriate tag
}else if(av_codec_get_id(job->ofmt_ctx->oformat->codec_tag,
in_stream->codecpar->codec_tag) ==
out_stream->codecpar->codec_id) {
// Specify codec_tag when the tag is valid in out stream codec
out_stream->codecpar->codec_tag = in_stream->codecpar->codec_tag;
}else{
out_stream->codecpar->codec_tag = 0;
}
#else
Expand Down