Skip to content

Fix tsconfig node_modules glob - #99

Open
liurenfeng94-ops wants to merge 1 commit into
tsperf:mainfrom
liurenfeng94-ops:fix-tsconfig-node-modules-glob
Open

Fix tsconfig node_modules glob#99
liurenfeng94-ops wants to merge 1 commit into
tsperf:mainfrom
liurenfeng94-ops:fix-tsconfig-node-modules-glob

Conversation

@liurenfeng94-ops

@liurenfeng94-ops liurenfeng94-ops commented Jul 28, 2026

Copy link
Copy Markdown

Fixes a hidden-character bug in tsconfig discovery.

getTsconfigFile was excluding node_modules with a glob that accidentally contained a zero-width character, so the exclusion could silently fail. This change moves the glob strings into a tiny shared helper and makes the node_modules exclusion explicit again.

The helper also gives us a small place to lock the glob values down in tests.

Validation:

  • pnpm vitest run test/tsconfig-search.test.ts
  • pnpm vitest run
  • pnpm typecheck
  • pnpm exec eslint .
  • pnpm build

@github-actions

Copy link
Copy Markdown

We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:

  1. Never let an LLM speak for you - all comments, issues, and PR descriptions should be written in your own words, reflecting your own understanding.
  2. Never let an LLM think for you - only submit contributions you fully understand and can explain.

Please review these AI-assisted contribution guidelines and update this contribution if needed.

If this was flagged in error, we apologise! 😳 Just let us know. 🙏

@liurenfeng94-ops

Copy link
Copy Markdown
Author

Thanks — I rewrote the description in my own words. The change is just the glob cleanup plus a tiny helper/test so the exclusion stays explicit and covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant