Skip to content

Extract trace duration formatter - #110

Open
liurenfeng94-ops wants to merge 1 commit into
tsperf:mainfrom
liurenfeng94-ops:extract-trace-duration-format
Open

Extract trace duration formatter#110
liurenfeng94-ops wants to merge 1 commit into
tsperf:mainfrom
liurenfeng94-ops:extract-trace-duration-format

Conversation

@liurenfeng94-ops

Copy link
Copy Markdown

Moves trace duration formatting out of the TreeNode template.

The template had the milliseconds conversion inline, which made the ?? fallback and /1000 expression easy to misread. This keeps the existing displayed value but puts the formatting in a small helper with coverage for defined and missing durations.

Validation:

  • pnpm vitest run test/trace-duration-format.test.ts
  • pnpm vitest run
  • pnpm typecheck
  • pnpm exec eslint .
  • pnpm build

@github-actions

Copy link
Copy Markdown

We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:

  1. Never let an LLM speak for you - all comments, issues, and PR descriptions should be written in your own words, reflecting your own understanding.
  2. Never let an LLM think for you - only submit contributions you fully understand and can explain.

Please review these AI-assisted contribution guidelines and update this contribution if needed.

If this was flagged in error, we apologise! 😳 Just let us know. 🙏

@liurenfeng94-ops

Copy link
Copy Markdown
Author

Thanks — I reviewed this again. This is a small extraction of the duration formatter out of the template so the milliseconds conversion is explicit and covered by tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant