Skip to content

Fix gotoLocation message type - #100

Open
liurenfeng94-ops wants to merge 1 commit into
tsperf:mainfrom
liurenfeng94-ops:fix-goto-location-type
Open

Fix gotoLocation message type#100
liurenfeng94-ops wants to merge 1 commit into
tsperf:mainfrom
liurenfeng94-ops:fix-goto-location-type

Conversation

@liurenfeng94-ops

@liurenfeng94-ops liurenfeng94-ops commented Jul 28, 2026

Copy link
Copy Markdown

Fixes a small shared message type mismatch.

GotoLocation was inferred from gotoPosition, so the exported TypeScript type had pos instead of the line and character fields that the gotoLocation schema accepts. This points the type alias at the matching schema and adds a small regression test around the message shape.

Validation:

  • pnpm vitest run test/goto-location-type.test.ts
  • pnpm vitest run
  • pnpm typecheck
  • pnpm exec eslint .
  • pnpm build

@github-actions

Copy link
Copy Markdown

We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:

  1. Never let an LLM speak for you - all comments, issues, and PR descriptions should be written in your own words, reflecting your own understanding.
  2. Never let an LLM think for you - only submit contributions you fully understand and can explain.

Please review these AI-assisted contribution guidelines and update this contribution if needed.

If this was flagged in error, we apologise! 😳 Just let us know. 🙏

@liurenfeng94-ops

Copy link
Copy Markdown
Author

Thanks — I rewrote the description to be clearer. This is just a type alias fix: the runtime schema already uses line/character, but the exported TypeScript type was pointing at the position message by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant