Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sp_sys_symlinknow takes a kind parameter. Making a link to a directory and making a link to a file are fundamentally different operations at the OS level, and omitting this at the call site forced us to choose between sniffing or accepting broken behavior.sp_sys_get_root_labelreturns the path of the Nth filesystem root on WASM, and nothing on native platforms.Several functions which used to return a
s64length and signal errors via a negative sentinel now returnsp_err_tsp_sys_open_dirnow accepts a flag,SP_SYS_OPEN_DIR_NO_FOLLOW, which closes the TOCTOU where a directory is swapped for a symlink mid-walkWe rewrote directory iteration to be layered:
Further unfucking of errors
Basic WASM filesystem support
Fixed
\on POSIX platforms; it's now a legal character in a pathStopped swallowing errors in the
sp_fs_atomic