Feature/lr#22
Open
ajwahab wants to merge 5 commits into
Open
Conversation
|
Works nicely, thanks!! I'd expect a visual indication of what's happening, though... :) |
Contributor
Author
|
Thanks! The meters bars will shift left/right as you adjust balance. I agree, adding a signed numeric indicator would help. Not sure I’m the right guy to start messing with the UI. I’m not 100% satisfied with how the volume is adjusted as balance shifts. I tried to maintain constant volume, but there’s a physiological or psychoacoustic aspect that isn’t properly accounted for. |
|
On 24/10/2025, 20:39, ajwahab wrote:
I’m not 100% satisfied with how the volume is adjusted as balance shifts. I tried to maintain constant volume, but there’s a physiological or psychoacoustic aspect that isn’t properly accounted for.
You're right, and I perceived it too. At the beginning it was hard for
me to tell if it was adjusting balance at all.
|
|
Inshallah this gets merged someday 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added channel balance control for stereo nodes. Shift+left/right increments balance towards the left/right channel whilst maintaining the loudest channel volume. Balance may be centered (reset to zero) with Shift+down. Subsequent volume adjustments respect the current balance setting.