No more nimble#153
Open
krux02 wants to merge 3 commits into
Open
Conversation
Author
|
not sure about this travis thing, there seems to be no CI running. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As you said, the compiler should be the build tool. And I 100% agree. The PR gets rid of nimble, nothing else.
Personal opinion: Regarding the
--noNimblePathin the nim.cfg, this shouldn't be necessary. If I want to compile with the nimble path, me or nimble when calling nim should add that path, not the other way around where I have to remove it wher I don't want to use nimble.PS:
This doesn't do anything else though. E.g. the opengl bindings https://glad.dav1d.de/ would be better than the ones from github.com/nim-lang, but I am not fixing that here. I just nail down opengl to one specific version using submodules instead of using a shitty package manager.