Skip to content

Add Windows 98 inspired app skin#8

Open
JZauner wants to merge 1 commit into
mainfrom
codex/apply-old-windows-skin-style
Open

Add Windows 98 inspired app skin#8
JZauner wants to merge 1 commit into
mainfrom
codex/apply-old-windows-skin-style

Conversation

@JZauner
Copy link
Copy Markdown
Contributor

@JZauner JZauner commented May 9, 2026

Motivation

  • Provide a purely cosmetic Windows 98-style skin for the Shiny app to give the UI a retro look while leaving functionality unchanged.

Description

  • Add a new stylesheet inst/app/www/windows-98.css implementing Win98 colors, chrome, fonts, and rules for navbars, cards, accordions, buttons, forms, tables, tooltips, and value boxes.
  • Wire the stylesheet into the app UI by adding a header link in R/LightLogWeb-app.R that references the resource at extr/windows-98.css.
  • Reuse the existing resource path registration addResourcePath("extr", system.file("app/www", package = "LightLogWeb")) so assets are served locally, and avoid adding new dependencies or JS.

Testing

  • Ran git diff --check to validate whitespace/patch issues and it succeeded.
  • Ran a Python check script to count CSS braces for basic syntax balance ({/}) and it succeeded.
  • Attempted R CMD check --no-manual --no-build-vignettes . but it could not run in this environment because R is not installed, so package checks and an interactive app launch were not performed.

Codex Task

@JZauner JZauner marked this pull request as ready for review May 9, 2026 10:05
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be78b667df

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

.btn-outline-danger,
.btn-outline-warning,
.btn-outline-primary,
button,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Exclude modal close buttons from global button skin

Because this selector applies the Win98 button background to every button, it also matches Bootstrap 5 modal close controls (button.btn-close). The background: ... !important in this rule resets the close control's built-in background image, so Shiny modals such as no_dataset_modal()/import_modal_successfull() lose their visible “X” close affordance; scope the skin to .btn/.action-button or explicitly exclude/restore .btn-close.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant