Add Windows 98 inspired app skin#8
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be78b667df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .btn-outline-danger, | ||
| .btn-outline-warning, | ||
| .btn-outline-primary, | ||
| button, |
There was a problem hiding this comment.
Exclude modal close buttons from global button skin
Because this selector applies the Win98 button background to every button, it also matches Bootstrap 5 modal close controls (button.btn-close). The background: ... !important in this rule resets the close control's built-in background image, so Shiny modals such as no_dataset_modal()/import_modal_successfull() lose their visible “X” close affordance; scope the skin to .btn/.action-button or explicitly exclude/restore .btn-close.
Useful? React with 👍 / 👎.
Motivation
Description
inst/app/www/windows-98.cssimplementing Win98 colors, chrome, fonts, and rules for navbars, cards, accordions, buttons, forms, tables, tooltips, and value boxes.R/LightLogWeb-app.Rthat references the resource atextr/windows-98.css.addResourcePath("extr", system.file("app/www", package = "LightLogWeb"))so assets are served locally, and avoid adding new dependencies or JS.Testing
git diff --checkto validate whitespace/patch issues and it succeeded.{/}) and it succeeded.R CMD check --no-manual --no-build-vignettes .but it could not run in this environment becauseRis not installed, so package checks and an interactive app launch were not performed.Codex Task