Skip to content

fix(runframe): use the embedded eval worker in CLI standalone mode #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
addibble wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(runframe): use the embedded eval worker in CLI standalone mode #3752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/components/RunFrameWithApi/standalone.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,17 @@ const runframeStandaloneProps: ComponentProps<typeof RunFrameWithApi> = {
/>,
)
} else if (window.TSCIRCUIT_USE_RUNFRAME_FOR_CLI) {
root.render(<RunFrameForCli {...runframeStandaloneProps} />)
// RunFrameForCli reads the embedded eval worker from `workerBlobUrl`, while the
// standalone build injects it as `evalWebWorkerBlobUrl` — map it explicitly so
// the embedded worker is used instead of forcing a CDN eval fetch.
// Props are forwarded by name (not spread), so any new standalone prop that
// RunFrameForCli should receive must be added here.
root.render(
<RunFrameForCli
workerBlobUrl={runframeStandaloneProps.evalWebWorkerBlobUrl}
enableFetchProxy={runframeStandaloneProps.enableFetchProxy}
/>,
)
} else {
const { fsMap } = await loadScriptsAsFsMap()
if (fsMap.size > 0) {
Expand Down
Loading