feat: implement PDIP-8 footprint via pdip/spdip aliases#655
Open
Guciolek wants to merge 1 commit into
Open
Conversation
- pdip (Plastic DIP) is electrically identical to DIP — same through-hole pads, same pitch - spdip (Shrink Plastic DIP) is also a DIP variant with same row spacing - Add aliases via normalizeDefinition regex - Add 4 test cases covering uppercase, lowercase, and parameterized variants - All existing 416 tests still pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #371
Adds
pdipandspdipas aliases for the existingdipfootprint implementation, so that strings likepdip8,PDIP8,spdip16,pdip8_p1.27mmall resolve to the same underlying DIP footprint.Changes
src/footprinter.ts: Add two regex aliases innormalizeDefinition:^pdip(?=[\d_]|$)→dip^spdip(?=[\d_]|$)→diptests/dip.test.ts: Add 4 test cases covering:pdip8resolves todip8spdip16resolves todip16PDIP8resolves todip8(case-insensitive)pdip8_p1.27mmresolves todip8_p1.27mmWhy aliases (not a new function)
PDIP(Plastic DIP) andSPDIP(Shrink Plastic DIP) are package name variants of the standard DIP family:For PCB footprint purposes (KiCad JLCPCB libraries, IPC-2221 conventions), they are identical to standard DIP and re-using the existing implementation:
Verification
All 416 existing tests in the footprinter repo pass:
Plus 4 new test cases for the aliases.
/claim #371