fix: reject conflicting file selectors - #156
Open
infosbighouse-glitch wants to merge 3 commits into
Open
infosbighouse-glitch wants to merge 3 commits into
infosbighouse-glitch wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent ambiguous file lookups when a request supplies a
file_idfor one file together with afile_pathfor another.Previously, the database lookup used OR semantics, so
/files/getand/files/downloadcould return whichever matching record appeared first. The routes now reject conflicting selectors with HTTP 400.Changes
file_id+file_pathin/files/getfile_id+file_pathin/files/downloadVerification
No project dependencies were installed or executed on the contributor machine. The patch is intentionally small and includes repository-native Bun regression coverage for CI to run remotely.
Closes part of #5
/claim #5