Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5
Summary
Hardens the download endpoints (
/files/download?...and/files/download/[[file_path]]), improves header sanitization and binary edge case handling, and documents the download API in the README.Key Changes
formatDownloadContentDispositionutility to sanitize filename quotes and linebreaks inContent-Disposition: attachment; filename="..."to prevent header injection while maintaining compatibility with existing consumers.if (!isText && file.binary_content_b64 !== undefined)so 0-byte binary files (binary_content_b64: "") are served asapplication/octet-streamwithContent-Length: 0instead of falling back to text.README.mdfor both query parameter style (/files/download?file_path=...and/files/download?file_id=...) and path parameter style (/files/download/path/to/file.txt).tests/routes/download-hardening.test.tstesting filenames with spaces, 0-byte binary files, and 404 responses across both query and path parameter styles.Verification
bun test: All 32 tests passed across 10 files (0 failures, 188 assertions)bun run format:check: Passed (Biome 100% clean)bun run build: Winterspec bundle and tsup CLI build succeeded cleanlybunx tsc --noEmit: Passed with 0 errors