fix: prevent compressed upstream responses from being truncated - #150
Open
Hello2021Year wants to merge 1 commit into
Open
Hello2021Year wants to merge 1 commit into
Hello2021Year wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an upstream sends gzip,
fetchdecodes the body but retains the compressedContent-Length. Forwarding that length truncates responses through the Node HTTP adapter: a 21,000-byte payload returned only 107 bytes with HTTP 200 in a local Node 22.22.0 reproduction.Drop the encoded length when forwarding a decoded response through
/proxyor the HTTP file proxy. Keep bodies streaming, preserve uncompressed lengths, and preserve the general proxy's HEAD length.Validation
/proxy, query/path downloads, and static file proxies. These catch the mismatch beforeBun.servecan repair the header: all four fail on the parent commit (176 vs 21,000 bytes) and pass with this change.bun test: 40 passed, 0 failed.bun run format:check,tsc --noEmit,bun run build, andgit diff --check: passed.winterspec/adapters/nodeon Node 22.22.0: all four affected paths returned the complete 21,000-byte payload after the fix.Implemented with AI assistance; the validation above was executed locally.