Skip to content

Document ammeter and multi-axis simulation graph controls#770

Open
ShiboSoftwareDev wants to merge 1 commit into
tscircuit:mainfrom
ShiboSoftwareDev:main
Open

Document ammeter and multi-axis simulation graph controls#770
ShiboSoftwareDev wants to merge 1 commit into
tscircuit:mainfrom
ShiboSoftwareDev:main

Conversation

@ShiboSoftwareDev

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Jun 29, 2026 3:04pm

Request Review

referenceTo=".V1 > .pin2"
graphDisplayName="VOUT"
graphCenter={3.3}
graphOffsetDivs={-1}

@seveibar seveibar Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just be graphVerticalOffset, not graphOffsetDivs

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or graphVerticalOffset

graphDisplayName="VOUT"
graphCenter={3.3}
graphOffsetDivs={-1}
graphUnitsPerDiv={0.05}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ive already said this- REMOVE "UNITS", graphVoltagePerDiv.

This api is not clear!

@seveibar seveibar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ammeter api is also wrong

graphDisplayName="IIN"
graphCenter={0.005}
graphOffsetDivs={1}
graphUnitsPerDiv={0.001}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
graphUnitsPerDiv={0.001}
graphCurrentPerDiv={0.001}

color="#e05a00"
graphDisplayName="IIN"
graphCenter={0.005}
graphOffsetDivs={1}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graphVerticalOffset="1mA"

@seveibar

Copy link
Copy Markdown
Contributor

Also the user should NOT need to specify those, they should be automatically computed- they should not appear in a code example IMO because 99% of the time they should be autocomputed (graphVerticalOffset and graphXXXPerDiv)

@seveibar

Copy link
Copy Markdown
Contributor

Also the graphCenter!!!!! The user will 99% of the time not specify them- please do nit include them in code samples!!!! They are an advanced almost entirely unused property that need their names fixed

@seveibar

Copy link
Copy Markdown
Contributor

Nobody wants to manually configure that when it can be done automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants