Skip to content

Respect disabled schematic trace auto labels#2448

Open
tongzhen1 wants to merge 2 commits into
tscircuit:mainfrom
tongzhen1:codex/sch-trace-auto-label-disabled
Open

Respect disabled schematic trace auto labels#2448
tongzhen1 wants to merge 2 commits into
tscircuit:mainfrom
tongzhen1:codex/sch-trace-auto-label-disabled

Conversation

@tongzhen1

Copy link
Copy Markdown

Summary

  • propagate schTraceAutoLabelEnabled into the schematic trace solver input
  • skip solver-generated and fallback schematic net labels when auto labels are explicitly disabled
  • add a regression test for board-level schTraceAutoLabelEnabled={false}

Fixes #2243

Testing

  • bun test tests/components/normal-components/sch-trace-auto-label-disabled.test.tsx tests/components/normal-components/resistor-pulldown.test.tsx
  • bun x biome check lib/components/primitive-components/Group/Group_doInitialSchematicTraceRender/Group_doInitialSchematicTraceRender.ts lib/components/primitive-components/Group/Group_doInitialSchematicTraceRender/createSchematicTraceSolverInputProblem.ts tests/components/normal-components/sch-trace-auto-label-disabled.test.tsx
  • npx --yes --package typescript@5.9.3 tsc --noEmit --pretty false

Propagate schTraceAutoLabelEnabled into schematic trace solver input and skip automatic net-label insertion when disabled.
Covers board-level schTraceAutoLabelEnabled={false} suppressing generated schematic_net_label elements.
@vercel

vercel Bot commented Jun 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview, Comment Jun 14, 2026 7:24pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

schTraceAutoLabelEnabled={false} has no observable effect on schematic rendering

1 participant