Wire startupProbe into workflows-backend and code-executor#306
Draft
marks wants to merge 2 commits into
Draft
Conversation
The .Values.startupProbe block already existed in values.yaml but was only consumed by deployment_backend.yaml. Mirror the same conditional into the workflows-backend and code-executor deployments so the existing values apply uniformly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.Values.startupProbeblock invalues.yamlwas previously only consumed bydeployment_backend.yaml. This wires the same conditional intodeployment_workflows.yamlanddeployment_code_executor.yamlso the existing values apply uniformly across the main backend, workflows-backend, and code-executor.startupProbe.enabledstill defaults tofalse, so this is a no-op for existing installs.Test plan
helm templatewith--set startupProbe.enabled=truerendersstartupProbe:blocks on all three deployments (backend port 3000, workflows-backend port 3000, code-executor port 3004).🤖 Generated with Claude Code