Document self-hosted same-origin agent-sandbox proxy (no extra ingress)#302
Draft
JatinNanda wants to merge 1 commit into
Draft
Document self-hosted same-origin agent-sandbox proxy (no extra ingress)#302JatinNanda wants to merge 1 commit into
JatinNanda wants to merge 1 commit into
Conversation
Clarify that leaving agentSandbox.frontendWsProxyDomain empty makes the backend serve the sandbox proxy same-origin via the main ingress, so no dedicated proxy domain or ingress object is required for self-hosted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents that, for self-hosted, leaving
agentSandbox.frontendWsProxyDomainempty makes the backend serve the agent-sandbox proxy same-origin via the main ingress — so no dedicated proxy domain orproxy.ingressobject is required, and a customer-managed catch-all ingress is left untouched.The chart already defaults the backend→controller/proxy env vars (
AGENT_EXECUTOR_*_INGRESS_DOMAIN) to in-cluster Service URLs and shipsproxy.ingress.enabled: false, so this is a values.yaml comment clarification only — no template/behavior change.The actual routing change lives in the backend: tryretool/retool_development#78870.
Test plan
helm templaterenders unchanged (comment-only edit).🤖 Generated with Claude Code