Skip to content

fix(desktop): don't quit on arbitrary timer expiry #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikolysz wants to merge 1 commit into from
Closed

fix(desktop): don't quit on arbitrary timer expiry #618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/paperback/src/ui/main_window.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,12 @@ impl MainWindow {
let dm_for_timer = Rc::clone(doc_manager);
let config_for_timer = Rc::clone(&config);
sleep_timer.on_tick(move |_| {
// Due to a wxdragon bug, on_tick runs all closures of all timers owned by this frame, not just this one.
// We unset sleep_timer_running_for_tick here. If it is already unset or the timer is still running,
// the event was intended for a different timer.
if !sleep_timer_running_for_tick.get() || sleep_timer_for_tick.is_running() {
return;
}
tracing::info!("sleep timer fired, closing application");
sleep_timer_running_for_tick.set(false);
sleep_timer_for_tick.stop();
Expand Down
Loading