Skip to content

fix: Create tokio runtimes before everything#218

Merged
load1n9 merged 2 commits into
mainfrom
fix/create-tokio-rt-before-everything
Jun 13, 2026
Merged

fix: Create tokio runtimes before everything#218
load1n9 merged 2 commits into
mainfrom
fix/create-tokio-rt-before-everything

Conversation

@marc2332

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented Jun 13, 2026

Copy link
Copy Markdown

Performance Comparison mainfix/create-tokio-rt-before-everything

Total Elapsed Time: 44.26ms → 40.76ms (-7.9%)
CPU Baseline: 89.84µs → 89.05µs (-0.9%)
Benchmark ID: timing

timing - Execution duration of functions.

+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+---------------------------------+---------------------------------+------------------------------+
| Function                            | Calls                | Avg                             | P50                             | P95                              | P99                             | Total                           | % Total                      |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+---------------------------------+---------------------------------+------------------------------+
| andromeda::main                     | 1 → 1 (+0.0%)        | 43.96ms → 40.47ms (-7.9%)       | 43.97ms → 40.47ms (-8.0%)       | 43.97ms → 40.47ms (-8.0%)        | 43.97ms → 40.47ms (-8.0%)       | 43.96ms → 40.47ms (-7.9%)       | 100.00% → 100.00% (+0.0%)    |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+---------------------------------+---------------------------------+------------------------------+
| andromeda::run_main                 | 1 → 1 (+0.0%)        | 43.94ms → 40.44ms (-8.0%)       | 43.97ms → 40.47ms (-8.0%)       | 43.97ms → 40.47ms (-8.0%)        | 43.97ms → 40.47ms (-8.0%)       | 43.94ms → 40.44ms (-8.0%)       | 99.95% → 99.94% (-0.0%)      |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+---------------------------------+---------------------------------+------------------------------+
| run::run                            | 1 → 1 (+0.0%)        | 43.25ms → 39.53ms (-8.6%)       | 43.25ms → 39.55ms (-8.6%)       | 43.25ms → 39.55ms (-8.6%)        | 43.25ms → 39.55ms (-8.6%)       | 43.25ms → 39.53ms (-8.6%)       | 98.38% → 97.69% (-0.7%)      |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+---------------------------------+---------------------------------+------------------------------+
| run::run_with_config                | 1 → 1 (+0.0%)        | 43.25ms → 39.53ms (-8.6%)       | 43.25ms → 39.55ms (-8.6%)       | 43.25ms → 39.55ms (-8.6%)        | 43.25ms → 39.55ms (-8.6%)       | 43.25ms → 39.53ms (-8.6%)       | 98.38% → 97.69% (-0.7%)      |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+---------------------------------+---------------------------------+------------------------------+
| Runtime::run                        | 1 → 1 (+0.0%)        | 23.43ms → 20.27ms (-13.5%)      | 23.45ms → 20.28ms (-13.5%)      | 23.45ms → 20.28ms (-13.5%)       | 23.45ms → 20.28ms (-13.5%)      | 23.43ms → 20.27ms (-13.5%)      | 53.30% → 50.08% (-6.0%)      |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+---------------------------------+---------------------------------+------------------------------+
| Runtime::new                        | 1 → 1 (+0.0%)        | 18.56ms → 18.30ms (-1.4%)       | 18.56ms → 18.32ms (-1.3%)       | 18.56ms → 18.32ms (-1.3%)        | 18.56ms → 18.32ms (-1.3%)       | 18.56ms → 18.30ms (-1.4%)       | 42.21% → 45.23% (+7.2%)      |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+---------------------------------+---------------------------------+------------------------------+
| Extension::load                     | 25 → 25 (+0.0%)      | 719.69µs → 711.01µs (-1.2%)     | 286.72µs → 284.16µs (-0.9%)     | 2.67ms → 2.63ms (-1.5%)          | 5.06ms → 5.03ms (-0.6%)         | 17.99ms → 17.78ms (-1.2%)       | 40.93% → 43.93% (+7.3%)      |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+---------------------------------+---------------------------------+------------------------------+
| ConsoleExt::internal_print          | 180 → 180 (+0.0%)    | 2.76µs → 3.21µs (+16.3%)        | 1.64µs → 1.57µs (-4.3%)         | 7.06µs → 6.67µs (-5.5%)          | 16.46µs → 17.34µs (+5.3%)       | 496.27µs → 577.26µs (+16.3%)    | 1.13% → 1.43% (+26.5%) ⚠️    |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+---------------------------------+---------------------------------+------------------------------+
| recommended::recommended_extensions | 1 → 1 (+0.0%)        | 58.16µs → 45.39µs (-22.0%) 🚀   | 58.17µs → 45.41µs (-21.9%) 🚀   | 58.17µs → 45.41µs (-21.9%) 🚀    | 58.17µs → 45.41µs (-21.9%) 🚀   | 58.16µs → 45.39µs (-22.0%) 🚀   | 0.13% → 0.11% (-15.4%)       |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+---------------------------------+---------------------------------+------------------------------+
| ConsoleExt::get_group_indent        | 180 → 180 (+0.0%)    | 151.00ns → 99.00ns (-34.4%) 🚀  | 101.00ns → 80.00ns (-20.8%) 🚀  | 430.00ns → 250.00ns (-41.9%) 🚀  | 591.00ns → 491.00ns (-16.9%)    | 27.26µs → 17.96µs (-34.1%) 🚀   | 0.06% → 0.04% (-33.3%) 🚀    |
+-------------------------------------+----------------------+---------------------------------+---------------------------------+----------------------------------+---------------------------------+---------------------------------+------------------------------+

Threads

+-----------------+-----------+-----------+
| Thread          | CPU % Avg | CPU % Max |
+-----------------+-----------+-----------+
| andromeda       |           |           |
+-----------------+-----------+-----------+
| hp-functions    |           |           |
+-----------------+-----------+-----------+
| hp-threads      |           |           |
+-----------------+-----------+-----------+
| hp-cpu-baseline |           |           |
+-----------------+-----------+-----------+

Generated with hotpath-rs

@load1n9 load1n9 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@load1n9 load1n9 merged commit 743e7ab into main Jun 13, 2026
10 checks passed
@load1n9 load1n9 deleted the fix/create-tokio-rt-before-everything branch June 13, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants