Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69377e41e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (dayShortcuts.length > 0) { | ||
| button.setAttribute("aria-keyshortcuts", dayShortcuts.join(" ")); | ||
| } | ||
| setDayActionShortcuts(button, gridActionSnapshot.length > 0, this.options.onDayContextMenu !== undefined); |
There was a problem hiding this comment.
Advertise F2 only when a visible grid action exists
When presentation modes differ by breakpoint, gridActionSnapshot can contain only an action hidden at the current container width. For example, with gridEventDisplay: { compact: "events", wide: "count" } and a single non-actionable event, the wide-only count button is hidden in compact mode, but this call still adds aria-keyshortcuts="F2"; pressing F2 is then prevented while focus remains on the day. This exposes a nonfunctional shortcut to assistive technology, so the shortcut state needs to track whether the current responsive presentation has an eligible action.
Useful? React with 👍 / 👎.
Summary
Busy days now default to a total-count button in compact calendars, making dense schedules easier to scan and activate. Wide calendars retain event summaries.
gridEventDisplaymodes andonEventOverflowActivatefor application-owned day choosers, with count-aware render hooks and preserved keyboard/focus behavior.mainthrough OIDC-onlynightlydelivery, retaining exact package/source/Pages evidence.latestremains on historical alpha until stable publication; historical releases stay frozen.Related work
None.
Verification
npm run checkpassed on6ddebb0bd84c852230246de58de51aec33a9cad5: 176 tooling tests, 295 unit tests, 290 Chromium/WebKit browser passes, one documented capability skip, zero flaky results, ten current screenshots, and dependency-free installed tarball verification including extension tree shaking and packed-byte DOM interaction. A second screenshot preparation confirmed current evidence without building or capturing.69377e41e890cfcdff3e04e5fb7b432dcf6718e8: 428 browser passes, five documented capability skips, and zero flaky results. The subsequent Firefox policy commit changes no runtime code; its generated package tarball has the identical SHA-256 digest.CIunset; hosted required checks use Chromium/WebKit.40cd4fashow faster default compact rendering in the measured scenarios. A 30-pair confirmation retained a legacy event-mode resize cost from 900 to 320 CSS px: median layout completion increased from 16.75 to 18.65 ms (+1.9 ms, +11.3%). Resize checks recorded zero DOM replacements, source calls, or hook invocations. These measurements do not establish universal performance parity.Risk and compatibility
gridEventDisplay: { compact: "events" }to preserve individual compact event presentation; review custom overflow visuals and count activation against the updated public contracts.npm-nightlytrusted-publisher binding and hosted controls. It introduces no npm token or secondary dist-tag writer. Public package and release Pages verification remain required after publication; this PR does not claim delivery is complete.Checklist
npm run checkwith the repository-selected Node.js and npm toolchain.Unreleasedchangelog.