Skip to content

Move to fedora-minimal - #347

Open
yairpod wants to merge 1 commit into
trusted-execution-clusters:mainfrom
yairpod:build_optimizing
Open

Move to fedora-minimal#347
yairpod wants to merge 1 commit into
trusted-execution-clusters:mainfrom
yairpod:build_optimizing

Conversation

@yairpod

@yairpod yairpod commented Aug 23, 2026

Copy link
Copy Markdown
Member

Change deployment base image from fedora to fedora-minimal

Fedora minimal reduces the base image size from uncompressed ~261MB to ~191MB.
This change requires no other changes from us.

Summary by Sourcery

Enhancements:

  • Switch all Fedora-based runtime images to Fedora Minimal to reduce the uncompressed base image size.

Change deployment base image from fedora to fedora-minimal

Signed-off-by: Yair Podemsky <ypodemsk@redhat.com>
@sourcery-ai

sourcery-ai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Switch all runtime stages in the Containerfile from the standard Fedora 43 base image to the lighter fedora-minimal 43 image, keeping build outputs and entrypoints unchanged.

File-Level Changes

Change Details Files
Update runtime container stages to use the fedora-minimal 43 base image instead of the full Fedora 43 image.
  • Change the operator stage base image to fedora-minimal:43
  • Change the attestation-key-register stage base image to fedora-minimal:43
  • Change the register-server stage base image to fedora-minimal:43
  • Change the compute-pcrs stage base image to fedora-minimal:43 while retaining existing copies and entrypoint
Containerfile

Possibly linked issues

  • #unknown: The PR replaces Fedora with Fedora Minimal for all runtime stages, reducing image size as requested.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="Containerfile" line_range="75" />
<code_context>

 # Distribution stages
-FROM quay.io/fedora/fedora:43 AS operator
+FROM quay.io/fedora/fedora-minimal:43 AS operator
 COPY --from=builder /output/operator /usr/bin
 ENTRYPOINT ["/usr/bin/operator"]
</code_context>
<issue_to_address>
**issue (broader_impact):** The runtime images do not install `ca-certificates`, so the Rust Kubernetes and HTTPS clients cannot verify the cluster API server or other TLS endpoints and fail with certificate-verification errors. The previous Fedora image supplied the system CA bundle that these dynamically linked OpenSSL/native-TLS clients rely on.

**Triggers:** When the Kubernetes API or configured Trustee/registration endpoints use TLS, which is the normal deployment configuration.

**Suggested fix:** Install `ca-certificates` in each minimal runtime stage, or retain a runtime base image that provides the CA bundle.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: Containerfile:75


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread Containerfile
@uril

uril commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

I think it 's better to do it only for 'release' not for 'debug', however doing that makes the Containerfile more complex.

In sourcery-ai review, missing 'ca-certificates' package is mentioned.

@yairpod

yairpod commented Aug 23, 2026

Copy link
Copy Markdown
Member Author

In sourcery-ai review, missing 'ca-certificates' package is mentioned.

Both images have the same 'ca-certificates' package. it should be a complete drop-in replacement.

@yairpod

yairpod commented Aug 23, 2026

Copy link
Copy Markdown
Member Author

I think it 's better to do it only for 'release' not for 'debug', however doing that makes the Containerfile more complex.

We could have it change depending by making the image a variable that gets different values depending on the value of build_type, but as you say, it's a more complex Containerfile.

@Jakob-Naucke Jakob-Naucke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it 's better to do it only for 'release' not for 'debug', however doing that makes the Containerfile more complex.

@uril when would that matter? even for debug builds, we don't include enough packages for e.g. a debugger (then you'd want libstdc++-debuginfo and others)

Comment thread Containerfile
@uril

uril commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

I think it 's better to do it only for 'release' not for 'debug', however doing that makes the Containerfile more complex.

when would that matter? even for debug builds, we don't include enough packages for e.g. a debugger (then you'd want libstdc++-debuginfo and others)

@Jakob-Naucke Yes, we can add those to debug builds (although we can do that with fedora-minimal too). Let's resolve this comment.

@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jakob-Naucke, yairpod

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants