Skip to content

Fix pyo3 Linux wheel cache compatibility#1090

Merged
trunk-io[bot] merged 1 commit into
mainfrom
codex/fix-pyo3-linux-cache-compat
May 12, 2026
Merged

Fix pyo3 Linux wheel cache compatibility#1090
trunk-io[bot] merged 1 commit into
mainfrom
codex/fix-pyo3-linux-cache-compat

Conversation

@dfrankland
Copy link
Copy Markdown
Member

Summary

  • split the rust-cache key for the pyo3 Linux workflow by target so x86_64 and aarch64 do not share one target cache
  • run x86_64 stub_gen inside the manylinux_2_28 container so cached Rust artifacts match the wheel build libc environment
  • keep aarch64 stub generation on the host path used by the cross build

Testing

  • git diff --check -- .github/actions/setup_rust_cargo/action.yaml .github/workflows/pyo3.yml
  • local commit hook checks passed on modified files

Split rust-cache keys by Linux target for the pyo3 workflow and run x86_64 stub generation inside the manylinux container so cached build artifacts stay libc-compatible with the wheel build.
@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 12, 2026

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

@trunk-staging-io
Copy link
Copy Markdown

trunk-staging-io Bot commented May 12, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@dfrankland dfrankland requested a review from TylerJang27 May 12, 2026 05:52
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.01%. Comparing base (e2604f0) to head (a793b50).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
+ Coverage   81.75%   82.01%   +0.26%     
==========================================
  Files          69       69              
  Lines       14917    14917              
==========================================
+ Hits        12195    12234      +39     
+ Misses       2722     2683      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 12, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@trunk-io trunk-io Bot merged commit 48daddd into main May 12, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants