Skip to content

Say that committing a qualifying badge value is permitted, never required - #33

Merged
trsdn merged 1 commit into
mainfrom
clarify-badge-committing-permission
Aug 31, 2026
Merged

trsdn merged 1 commit into
mainfrom
clarify-badge-committing-permission

Conversation

@trsdn

@trsdn trsdn commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Problem

Found by the first repository assessed against 1.6.0 (trsdn/PtionsPlus#35), which checked P08 against the rule text before recording a result and hit two readings of it.

The committing bullet names license, platform, and conformance as qualifying for a committed image. The next bullet granted a Pass to a live third-party image "everywhere else". Read together, those three values are not "everywhere else", so the text left them with no stated result at all — neither Pass nor Partial nor Fail. That lets may be committed be read as must be committed, which is the opposite of what 1.6.0 intended.

What actually decided that assessment was the 1.6.0 changelog line "No recorded result can turn into a Fail from any of this", not the rule. A criterion that needs its changelog to be assessable has the same defect 1.6.0 set out to remove from "where practical".

Change

  • The permission is explicit: license, platform, and conformance qualify, "and committing them is permitted, never required".
  • The Pass is tied to the absence of a first-party image rather than to "everywhere else", and says it holds "whether or not that value would also qualify for committing".

Version

Patch, 1.6.1. Wording without altered meaning. No recorded result changes: P08: pass in PtionsPlus holds under both the old and the new text, and this repository's own P08: pass is unaffected. The record is repointed to 1.6.1 with the same assessed_on, because nothing was reassessed — only the version the catalog carries moved.

Verification

python3 scripts/standard.py --check      # 93 criteria, catalog in sync
python3 scripts/conformance.py --check   # Healthy (na=39, pass=54), badge in sync
python3 scripts/links.py                 # internal links resolve across 26 Markdown files
python3 -m unittest discover -s tests    # 71 tests, OK
npx markdownlint-cli2@0.18.1 "**/*.md"   # 0 errors

Ruff not run locally (pipx unavailable); no Python source changed, CI covers it.

v1.6.0 stays tagged and valid, so repositories pinned to it — including PtionsPlus#35 — keep validating against the exact text they were assessed with.

…ired

The first repository assessed against 1.6.0 read the badge rules twice and got
two answers. The committing bullet names licence, platform, and conformance as
qualifying for a committed image; the next bullet gives a `Pass` to a live
third-party image "everywhere else". Those three values are not "everywhere
else", so the text left them with no stated result, and `may` could be read as
`must`.

The permission is now explicit, and the `Pass` is tied to the absence of a
first-party image rather than to "everywhere else". Nothing changes for any
recorded result: 1.6.0 already ruled out the reading that would turn a `Pass`
into a `Fail`. This puts that in the rule instead of the changelog.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9b1752df-b072-40bc-b7bb-b985d12dd604
@trsdn
trsdn merged commit d05c50f into main Aug 31, 2026
6 checks passed
@trsdn
trsdn deleted the clarify-badge-committing-permission branch August 31, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant