Say that committing a qualifying badge value is permitted, never required - #33
Merged
Merged
Conversation
…ired The first repository assessed against 1.6.0 read the badge rules twice and got two answers. The committing bullet names licence, platform, and conformance as qualifying for a committed image; the next bullet gives a `Pass` to a live third-party image "everywhere else". Those three values are not "everywhere else", so the text left them with no stated result, and `may` could be read as `must`. The permission is now explicit, and the `Pass` is tied to the absence of a first-party image rather than to "everywhere else". Nothing changes for any recorded result: 1.6.0 already ruled out the reading that would turn a `Pass` into a `Fail`. This puts that in the rule instead of the changelog. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9b1752df-b072-40bc-b7bb-b985d12dd604
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Found by the first repository assessed against 1.6.0 (trsdn/PtionsPlus#35), which checked
P08against the rule text before recording a result and hit two readings of it.The committing bullet names license, platform, and conformance as qualifying for a committed image. The next bullet granted a
Passto a live third-party image "everywhere else". Read together, those three values are not "everywhere else", so the text left them with no stated result at all — neitherPassnorPartialnorFail. That letsmay be committedbe read asmust be committed, which is the opposite of what 1.6.0 intended.What actually decided that assessment was the 1.6.0 changelog line "No recorded result can turn into a
Failfrom any of this", not the rule. A criterion that needs its changelog to be assessable has the same defect 1.6.0 set out to remove from "where practical".Change
Passis tied to the absence of a first-party image rather than to "everywhere else", and says it holds "whether or not that value would also qualify for committing".Version
Patch, 1.6.1. Wording without altered meaning. No recorded result changes:
P08: passin PtionsPlus holds under both the old and the new text, and this repository's ownP08: passis unaffected. The record is repointed to 1.6.1 with the sameassessed_on, because nothing was reassessed — only the version the catalog carries moved.Verification
Ruff not run locally (
pipxunavailable); no Python source changed, CI covers it.v1.6.0stays tagged and valid, so repositories pinned to it — including PtionsPlus#35 — keep validating against the exact text they were assessed with.