fix(toolkit): set witness flag for fork accounts#122
Open
Federico2014 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes
toolkitdb forkwitness account initialization.accountstore withisWitness=truewhen processingwitnessesinDbForkALLOW_MULTI_SIGN == 1, initialize default witness permissions for witness accounts that do not already havewitnessPermissionwitnessPermissionif it is already configured, instead of overwriting itDbForkWhy are these changes required?
Before this change,
db forkupdated thewitnessstore but did not fully initialize the corresponding witness account state inaccountstore.This caused two problems:
db forkcould miss theisWitnessflagwitnessPermission, which makes the forked database inconsistent with runtime witness-account initialization logicThis PR makes
db forkproduce witness account data that is compatible with multi-sign behavior while remaining safe for accounts that already have customized witness permissions.This PR has been tested by:
./gradlew :toolkit:test --tests org.tron.plugins.DbForkTestFollow up
Extra details
ALLOW_MULTI_SIGNandACTIVE_DEFAULT_OPERATIONSare read from the dynamic properties storewitnessPermission