Skip to content

Commit f9ab113

Browse files
committed
Polish errors page: ellipsis on Configure alerts, center loading spinner
Add a U+2026 ellipsis to the 'Configure alerts' button on the errors list and detail pages to signal it opens a panel rather than acting inline. Center the error-detail Suspense fallback by giving it h-full so the spinner sits in the middle of the page instead of pinned to the top.
1 parent 0f9333f commit f9ab113

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

  • apps/webapp/app/routes
    • _app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors.$fingerprint
    • _app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors._index

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors.$fingerprint/route.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -331,16 +331,16 @@ export default function Page() {
331331
LeadingIcon={BellAlertIcon}
332332
leadingIconClassName="text-alerts"
333333
>
334-
Configure alerts
334+
Configure alerts
335335
</LinkButton>
336336
</PageAccessories>
337337
</NavBar>
338338

339339
<PageBody scrollable={false}>
340340
<Suspense
341341
fallback={
342-
<div className="my-2 flex items-center justify-center">
343-
<div className="mx-auto flex items-center gap-2">
342+
<div className="flex h-full items-center justify-center">
343+
<div className="flex items-center gap-2">
344344
<Spinner />
345345
<Paragraph variant="small">Loading error details…</Paragraph>
346346
</div>

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors._index/route.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ function FiltersBar({
464464
LeadingIcon={BellAlertIcon}
465465
leadingIconClassName="text-alerts"
466466
>
467-
Configure alerts
467+
Configure alerts
468468
</LinkButton>
469469
{list && <ListPagination list={list} />}
470470
</div>

0 commit comments

Comments
 (0)