Skip to content

Commit 0f9333f

Browse files
committed
Move Configure alerts button to the page title bar
Matches the prior PageAccessories pattern used on /alerts, /deployments, /bulk-actions, etc. — drops the in-sidebar header row so 'Details' stands on its own.
1 parent a41f799 commit 0f9333f

1 file changed

Lines changed: 13 additions & 20 deletions

File tree

  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors.$fingerprint

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors.$fingerprint/route.tsx

Lines changed: 13 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import {
2727
import { type NextRunList } from "~/presenters/v3/NextRunListPresenter.server";
2828
import { $replica } from "~/db.server";
2929
import { logsClickhouseClient, clickhouseClient } from "~/services/clickhouseInstance.server";
30-
import { NavBar, PageTitle } from "~/components/primitives/PageHeader";
30+
import { NavBar, PageAccessories, PageTitle } from "~/components/primitives/PageHeader";
3131
import { PageBody } from "~/components/layout/AppLayout";
3232
import {
3333
ResizableHandle,
@@ -324,6 +324,16 @@ export default function Page() {
324324
}}
325325
title={<span className="font-mono text-xs">{ErrorId.toFriendlyId(fingerprint)}</span>}
326326
/>
327+
<PageAccessories>
328+
<LinkButton
329+
to={alertsHref}
330+
variant="secondary/small"
331+
LeadingIcon={BellAlertIcon}
332+
leadingIconClassName="text-alerts"
333+
>
334+
Configure alerts
335+
</LinkButton>
336+
</PageAccessories>
327337
</NavBar>
328338

329339
<PageBody scrollable={false}>
@@ -366,7 +376,6 @@ export default function Page() {
366376
projectParam={projectParam}
367377
envParam={envParam}
368378
fingerprint={fingerprint}
369-
alertsHref={alertsHref}
370379
/>
371380
);
372381
}}
@@ -385,7 +394,6 @@ function ErrorGroupDetail({
385394
projectParam,
386395
envParam,
387396
fingerprint,
388-
alertsHref,
389397
}: {
390398
errorGroup: ErrorGroupSummary | undefined;
391399
runList: NextRunList | undefined;
@@ -394,7 +402,6 @@ function ErrorGroupDetail({
394402
projectParam: string;
395403
envParam: string;
396404
fingerprint: string;
397-
alertsHref: string;
398405
}) {
399406
const { value, values } = useSearchParams();
400407
const organization = useOrganization();
@@ -510,11 +517,7 @@ function ErrorGroupDetail({
510517
{/* Right-hand detail sidebar */}
511518
<ResizableHandle id="error-detail-handle" />
512519
<ResizablePanel id="error-detail" min="280px" default="380px" max="500px" isStaticAtRest>
513-
<ErrorDetailSidebar
514-
errorGroup={errorGroup}
515-
fingerprint={fingerprint}
516-
alertsHref={alertsHref}
517-
/>
520+
<ErrorDetailSidebar errorGroup={errorGroup} fingerprint={fingerprint} />
518521
</ResizablePanel>
519522
</ResizablePanelGroup>
520523
);
@@ -523,24 +526,14 @@ function ErrorGroupDetail({
523526
function ErrorDetailSidebar({
524527
errorGroup,
525528
fingerprint,
526-
alertsHref,
527529
}: {
528530
errorGroup: ErrorGroupSummary;
529531
fingerprint: string;
530-
alertsHref: string;
531532
}) {
532533
return (
533534
<div className="grid h-full grid-rows-[auto_1fr] overflow-hidden bg-background-bright">
534-
<div className="flex items-center justify-between border-b border-grid-dimmed py-2 pl-3 pr-2">
535+
<div className="border-b border-grid-dimmed px-3 py-2">
535536
<Header2 className="truncate">Details</Header2>
536-
<LinkButton
537-
to={alertsHref}
538-
variant="secondary/small"
539-
LeadingIcon={BellAlertIcon}
540-
leadingIconClassName="text-alerts"
541-
>
542-
Configure alerts
543-
</LinkButton>
544537
</div>
545538
<div className="overflow-y-auto px-3 py-3 scrollbar-thin scrollbar-track-transparent scrollbar-thumb-charcoal-600">
546539
<div className="flex flex-col gap-4">

0 commit comments

Comments
 (0)