Skip to content

repro: preserve successful stage gitignore entries - #11094

Draft
aryansk wants to merge 1 commit into
treeverse:mainfrom
aryansk:ops074/dvc-11091
Draft

repro: preserve successful stage gitignore entries#11094
aryansk wants to merge 1 commit into
treeverse:mainfrom
aryansk:ops074/dvc-11091

Conversation

@aryansk

@aryansk aryansk commented Sep 2, 2026

Copy link
Copy Markdown

Fixes #11091

When a pipeline stage completes, keep its generated .gitignore entries committed to the reproduction result. If a later stage fails, only ignore entries created by the failing operation should be rolled back.

  • ❗ I have followed the Contributing to DVC checklist.
  • 📖 This PR does not require documentation updates.

Validation:

  • PATH="$PWD/.venv/bin:$PATH" .venv/bin/pytest -q tests/func/repro/test_repro.py
  • PATH="$PWD/.venv/bin:$PATH" .venv/bin/pytest -q tests/unit/repo/test_reproduce.py tests/unit/repo/test_scm_context.py
  • .venv/bin/mypy dvc/repo/reproduce.py dvc/repo/scm_context.py
  • ruff check and ruff format --check on changed files.

@github-project-automation github-project-automation Bot moved this to Backlog in DVC Sep 2, 2026
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.98%. Comparing base (2431ec6) to head (f20b57f).
⚠️ Report is 213 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11094      +/-   ##
==========================================
+ Coverage   90.68%   90.98%   +0.30%     
==========================================
  Files         504      505       +1     
  Lines       39795    41146    +1351     
  Branches     3141     3263     +122     
==========================================
+ Hits        36087    37436    +1349     
- Misses       3042     3071      +29     
+ Partials      666      639      -27     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dvc repro: rolls back .gitignore entries for successful stages when a later stage fails

2 participants