Development - #114
Open
treblereel wants to merge 15 commits into
Open
Conversation
Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com>
Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com>
Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com>
Remove javax.xml and org.w3c.dom emulation classes now provided by stdlib 0.8. Update j2cl platform to 20260527-1, GWT to 2.13.0, and Java source/target to 17 for samples. Add j2cl super-source module descriptor. Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com>
Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com>
…veXMLReader The browser's DOMParser produces these node types (7, 8, 10) when parsing XML with DOCTYPE declarations and comments. The visit() method only handled types 1-4 and 9, throwing UnsupportedOperationException for anything else. Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com>
Only strip whitespace text nodes when the parent also has element children (formatting whitespace between elements). When the parent has only text children, the whitespace is legitimate content and must be preserved. Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com>
J2CL's Double.toString()/Float.toString() uses JavaScript's native string conversion which produces "1" instead of "1.0" for whole numbers. Update expected XML strings to match the J2CL platform behavior. Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com>
…amespace handling createElement/setAttribute don't support XML namespaces in browser DOM, causing failures for prefixed elements (e.g. bpmn40:value5) and namespace declarations. Switch to createElementNS/setAttributeNS and add namespace lookup for prefixed attributes. Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com>
…format code - Fix duplicate import conflicts in MapperSuite.java using FQN for ambiguous classes - Remove duplicate getModuleName() and import in primitive/BooleanTest.java - Replace Assert.assertEquals with assertEquals in NamespaceTest (test2, test3, test4) - Skip surefire tests (GWTTestCase requires GWT DevMode, not standard surefire) - Auto-format 77 files to comply with fmt-maven-plugin Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com>
- Replace maven-version-test with java-version-test (Java 17, 21, 25) - Add browser-actions/setup-chrome for J2CL browser tests - Bump actions/setup-java to v5 - Include tests-j2cl in CI, exclude only tests-gwt2 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- processor: use annotationProcessorPaths for auto-service instead of classpath discovery (broken by JEP 477 in Java 23+), add ServicesResourceTransformer to shade plugin for proper SPI merging - tests/jre: move processor from classpath dependency to annotationProcessorPaths for Java 25 compatibility - CI: exclude tests-j2cl on Java 17 (J2CL deps require class version 65/Java 21), setup Chrome only when running J2CL tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
createElementNS causes XMLSerializer to suppress xmlns="..." attributes
since it considers the namespace already declared at the element level.
Use createElement + setAttribute("xmlns", ...) for unprefixed elements
so the namespace declaration appears as a regular attribute in output.
Keep createElementNS only for prefixed elements (e.g. bpmn40:value5).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lookupNamespaceURI may not work on createElement elements in Chrome. Use a HashMap to track prefix->namespace bindings from writeNamespace calls, and look up from it in writeAttribute for prefixed attributes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use attr.localName instead of stripping only xsi: prefix from attr.name. This correctly handles all namespace prefixes (drools:, bpmn40:, etc.) when looking up attribute names in the deserializer property map. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.