Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Reuse a single Faraday HTTP client for each
Trino::Clientinstance.Currently, query operations create a new Faraday client for each request.
Reusing the client reduces connection and TLS handshake overhead and enables HTTP keep-alive with a compatible Faraday adapter.
This PR is based on the idea and implementation proposed in #137. Since that PR has not been updated for over a year, this PR provides a fresh implementation for the current codebase with expanded test coverage.
Thank you to @redox for the original proposal and implementation.
Overview
Trino::ClientinstanceChecklist