nav: drop downstream-demo references from material.h + nav_material_deploy_test comments - #544
Merged
Merged
Conversation
…test comments libcvc core should not name a cvc::dbg demo. These were comment-only mentions of 'demo3' (the DBG convoy demo): a force-bias-slider example in material.h and --grip startup-crash regression notes in nav_material_deploy_test. Generalized the wording (kept the cvcdbg #141 regression traceability); no code change. Companion to the async_lane demo3 rename in the LaneTaskTest-flake PR.
transfix
enabled auto-merge
October 2, 2026 17:10
transfix
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libcvc core shouldn't name a downstream application's demo. Companion to #542 (which removed the same demo name from
async_lane); together they clear all references to that demo from libcvc core.Comment-only mentions of a downstream demo, generalized:
material.h: the force-bias-slider example no longer names the demo → now "e.g. a live UI force-bias slider".nav_material_deploy_test.cpp: the--gripstartup-crash regression notes no longer name the demo (kept the downstream issue-number regression traceability).No code change.