Shape polar duplicate: show permanent sketch nodes in inspection and polar-duplicate modes#103
Open
trailcode wants to merge 5 commits into
Open
Shape polar duplicate: show permanent sketch nodes in inspection and polar-duplicate modes#103trailcode wants to merge 5 commits into
trailcode wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Permanent "+" markers for user-placed sketch nodes (added via the Add Node tool) are now visible whenever a sketch is active in inspection mode or during Shape polar duplicate (which relies on sketch node snapping for the polar arm).
Previously, these nodes were only shown while actively using the Add Node tool (
Sketch_add_node); they were hidden inSketch_inspection_modeandShape_polar_duplicate.Changed the visibility condition in
sync_permanent_node_annos_()from an explicit mode check tois_sketch_mode(mode) || mode == Mode::Shape_polar_duplicate.Files changed
src/sketch.cppRelated
Test plan
Notes
third_party/ImGuiColorTextEdit/