release-train: staging -> main - #476
Merged
Merged
Conversation
…connection (#466) The pageInfo stripper loop in the Bugbot gate selftest ended in a `break`, so only the first member of PAGED_TOPLEVEL (checkSuites) was ever exercised. Its reviewThreads branch pasted a fixed 6-space indentation into str.replace, a needle that is a substring of the 14-space checkSuites line, so even when reached it stripped checkSuites' pageInfo again and the detector answered ['checkSuites']. A pageInfo self-check blind to reviewThreads alone passed the suite. The loop now mirrors the totalCount stripper: literal member list beside the module's dict (a removed member fails), a name-anchored indentation-agnostic regex with its substitution count asserted, the detector required to name exactly the stripped connection, and the visit list compared to the literals so a reintroduced break reddens the suite. A registry mutation pins the reviewThreads-only regression; it was UNCAUGHT against the old suite and is caught now. Tracked internally (Bugbot finding on the staging promotion #464). Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…line, not the random fixture sha (#468) The "is NOT attributed" assertions grepped the whole extractor output for a three-digit PR number. That output also carries `::warning::commit <40-hex sha>` for the subject-fallback path, and the fixture commits are minted at run time, so their shas are random hex: whenever one contained the needle the assertion failed with the extractor itself correct. That is what reddened `selftests` on main at eb89c1e (fixture sha e57d5bafc191901afac..., needle "901"), roughly 1% of runs per needle. Grep only the `Found PRs:` line -- the attribution the checks are about. Mutation-proved: dropping the release-train exclusion from the extractor reddens the narrowed "promotion" check (Found PRs: 900 901). Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
release-train: develop -> staging
release-train: develop -> staging
…473) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
release-train: develop -> staging
Contributor
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit bae90d1. Configure here.
tracebloc-release-train
Bot
added
gate-nudge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated promotion by the release train (RFC-0008 D14). Head is the train-managed
release-train/to-mainbranch (a mirror ofstaging), so it never collides with a human PR. Merged only when the fr-gate is green.Note
Low Risk
Changes are documentation and test-only hardening; no production gate or extractor logic appears in this diff.
Overview
Release train promotion bundles a small docs tweak and two selftest hardening fixes that were failing or blind in CI.
The GitHub profile README now points the training notebook at the
quickstartrepo instead ofstart-training.Bugbot gate tests no longer stop after the first paged GraphQL connection when simulating a missing
pageInfofield: the suite walkscheckSuitesandreviewThreads, uses per-connection stripper assertions, and a new mutation case pins the regression where only the first connection was checked (soreviewThreadscould lose cursors unnoticed).extract-advanced-prsselftest scopes “must not attribute” checks to theFound PRs:line only, so random commit SHAs in warning output no longer cause ~1% flaky failures when grepping for issue/PR numbers like901or979.Reviewed by Cursor Bugbot for commit bae90d1. Bugbot is set up for automated code reviews on this repo. Configure here.