fix: honor updateRef when creating signed commits - #225
Merged
Conversation
|
@xxxxxxjun is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commit()ignoredupdateRefwhen asignaturewas given, leaving the signedcommit unreachable. The signed path now does what libgit2 already does for
unsigned commits.
Changes
updateRefbefore writing the object, then point it at the new commit.Covers symbolic refs, unborn HEAD, and refs that don't exist yet.
updateRef. Thecheck runs before
commit_signed(), so a rejected commit leaves nothing in the odb.Notes
The first-parent check goes beyond the reported bug and turns a silent success
into an error. Without it, moving the ref on a mismatched first parent would let
a branch jump across history. Everything that pairs
signaturewithupdateReftoday (the existing test and the two
usage/commit.mdexamples) already passesthe current tip.
Closes #218