Skip to content

fix: Honor updateRef when creating signed commits #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VedantMadane wants to merge 1 commit into from
Closed

fix: Honor updateRef when creating signed commits #224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/commit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,9 +444,23 @@ impl Repository {

let commit_content_str = std::str::from_utf8(&commit_content)?.to_string();

self
let oid = self
.inner
.commit_signed(&commit_content_str, &signature_str, signature_field.as_deref())?
.commit_signed(&commit_content_str, &signature_str, signature_field.as_deref())?;

// commit_signed only writes the object; honor update_ref like the unsigned path.
if let Some(name) = update_ref.as_deref() {
match self.inner.find_reference(name) {
Ok(mut reference) => {
reference.set_target(oid, "commit (signed)")?;
}
Err(_) => {
self.inner.reference(name, oid, true, "commit (signed)")?;
}
}
}

oid
} else {
self.inner.commit(
update_ref.as_deref(),
Expand Down