docs(deps): name the real linking mechanism in the worklets override comment - #122
Merged
Merged
Conversation
…comment The comment justifying the workspace-wide `overrides` block attributed the pin to expo-modules-autolinking binding a 0.12.x copy of the package. Verified against the installed tree: neither react-native-worklets nor react-native-reanimated ships an expo-module.config.json, so neither is an Expo module — `expo-modules-autolinking search -p ios` returns expo-modules-core and not these two. They are linked by React Native's own autolinking. The binding constraint is one layer down: which react-native-worklets copy expo-modules-core is peer-resolved against. The @expo/ui / expo-router graph bound it to 0.12.x, which is why declaring the versions in apps/mobile does not help and a workspace-wide override does. The pin itself is correct and unchanged — only its stated reason was wrong, and this comment is the sole durable record of why the override exists. Comment-only: `overrides` values, apps/mobile/package.json and pnpm-lock.yaml are untouched; `pnpm install --frozen-lockfile` reports already up to date. Closes #121 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #121
Follow-up to #119, found while reviewing it. Comment-only — the pin is correct and unchanged.
What was wrong
#119's
overridescomment justified the workspace-wide pin like this:Checked against the installed tree:
react-native-workletsnorreact-native-reanimatedships anexpo-module.config.json, so neither is an Expo module.expo-modules-autolinking search -p iosreturnsexpo-modules-coreand not these two — they are linked by React Native's own community autolinking.react-native-workletscopyexpo-modules-coreis peer-resolved against. That is the copy whose headersExpoWorkletsBridgeProvider.mmcompiles against, and the@expo/ui/expo-routergraph bound it to 0.12.x.The conclusion #119 reached — declare in
apps/mobileand override workspace-wide — is right, and the reason for it survives the correction: a dependency entry inapps/mobiledoes not change whatexpo-modules-coreis peer-resolved against, so only the override removes the 0.12.x copy from the graph.Why a comment is worth a PR
This is the only durable record of why the override exists, and CLAUDE.md requires a rejected alternative to be recorded with its reason. A wrong reason is a defect in the record, not a cosmetic issue: the concrete failure mode is a future reader testing whether Expo autolinking picks up the package, concluding from a null result that the override is unnecessary, and reintroducing #117.
Verification
pnpm install --frozen-lockfile—Already up to date;git statusshowspnpm-workspace.yamlas the only modified filepnpm why react-native-worklets—react-native-worklets@0.10.1, single versionpnpm build6/6,pnpm test6/6overridesvalues,apps/mobile/package.jsonandpnpm-lock.yamlare untouched.🤖 Generated with Claude Code