The docs read against the graph diff - #173
Merged
Merged
Conversation
The release doc pass over timbersh-v0.8.0..main, which is timbergraph and the `graph` statement, plus the one defect reading them found. - The refusal for samples that already carry a `host` label named an undefined variable, so raising it raised a NameError from inside the shell instead. Tested, and the test fails without the fix. - A `.B` request mid-line in timbersh(1) put the literal `.B "graph M from SRC extracting NAME"` in the rendered page. - `--width`/`--height` had neither help text nor a man entry. - The grammar `\?` prints — which timbersh(1) calls the authority — knew `png` but not `svg` or `using`. - Recommends: timberfs (>= 0.32.0), for `extracting`: it runs `timberfs tally --try` here and resolves a name against the packaged extractor directory.
The same shortcoming as the Rust side: a reading directory is listed only if it exists, so where none does the message named nowhere at all. It names all three now. The test replaces the directory list rather than skipping where a real one exists — a test that runs on some machines and not others has told you nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release doc pass for
timbersh-v0.9.0—timbersh-v0.8.0..main, which istimbergraphand thegraphstatement (#171). Reading the prose against thecode found one real defect and four gaps.
The defect
graphrefuses samples that already carry ahostlabel, because the shelladds one itself. The message named
metric, which is not bound —metricsis— so raising the refusal raised
NameError: name 'metric' is not definedfrominside the shell instead. Fixed, and the new test fails without the fix:
The gaps
.Brequest sitting mid-line intimbersh(1)is not a request: therendered page carried the literal
.B "graph M from SRC extracting NAME".Swept every man page for the same shape — this was the only one, and all six
render with no
--warnings=alloutput.--width/--heighthad no help text and no man entry. They are characterson the terminal and pixels in an image, which is worth writing down.
\?prints — whichtimbersh(1)explicitly calls the authority,"this page deliberately does not copy it" — listed
pngbut neithersvgnor
using. Both, and the parse error beside it, now do.tools/README.mddocumented--usingundertimbergraphand nevermentioned that the
graphstatement has the same clause.Packaging
Recommends: timberfs (>= 0.26.0)→>= 0.32.0.graph ... extractingrunstimberfs tally --trylocally and resolves an extractor name against thedirectory the timberfs package ships; both landed in 0.32.0. Still a
Recommends and still only a hint — the case that matters is a remote target,
about which a dpkg constraint says nothing, so the runtime diagnosis stays the
real guard.
⚠ Merge order: this names 0.32.0, so
v0.32.0ships first andtimbersh-v0.9.0is tagged only after its apt-repo rebuild has finished — thetwo tags must never be pushed concurrently.